FLUID-2100: Fix and code review

Li, Cindy cli at ocad.ca
Wed Aug 11 12:37:14 UTC 2010


Thanks for the code review, Colin. Quite encouraging to see my very first patch made into fluid trunk. Many thanks to Justin for going through the whole process with Harris and I and found some simple issues to get us start.

Cheers!

Cindy
________________________________________
From: Colin Clark [colinbdclark at gmail.com]
Sent: 10 August 2010 18:59
To: Li, Cindy
Cc: fluid-work at fluidproject.org
Subject: Re: FLUID-2100: Fix and code review

Hi Cindy,

Great patch, and thanks for the accompanying unit test, too! I reviewed your code and committed the fix to Infusion, resolving FLUID-2100.

Keep the patches rolling,

Colin

On 2010-08-06, at 3:29 PM, Li, Cindy wrote:
> As a good start, I fixed this little bug, which is to set the tooltip for inline editor to be on by default. The patch is attached and your code review is appreciated!
>
> http://issues.fluidproject.org/browse/FLUID-2100

---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org




More information about the fluid-work mailing list