code for FLUID-2925

[Laurel A. Williams]

Hi Colin,

Thanks for the really useful thoughts.
 
I am also aware that the code so far is seriously lacking in error 
checking and input validation in many ways (lots of TODO notes there). 
Also on my task list is some automated testing code - right now I am 
doing manual testing using debug statements - silliness. I noted to 
Jacob that we hadn't really confirmed what the request parameters would 
be, though he is correct that we put something in for testing. I'll make 
sure to account for that in the code. At the time I wrote the code, I 
don't think we had even put in the minified/src buttons. This speaks to 
how quickly things are developing on this task!

I hadn't read the license policy, so yes, it was just a cut and paste. 
Thanks for the link so that I can read it over.

Laurel


Colin Clark wrote:
> Hey Laurel and Jacob,
>
> Couple of quick comments inline...
>
> On 12-Jun-09, at 9:10 AM, Jacob Farber wrote:
>> When looking for the minification flag, it looks like your checking 
>> whether or not the variable is set.
>> Im not 100% sure, but I think which Justin's latest form setup you 
>> will always have a set value for compression ("minified" vs. 
>> "source") as opposed to true vs. null.
>
> It's never a bad thing to check for the presence of a value before 
> operating on it. With a web service, it's better to not make 
> assumptions just because you know how the client-side implementation 
> works.
>
>>> Jacob - can you review this code and let me know if there is anything
>>> you would like to see altered or fixed? I can provide the generalized
>>> config.php asap (tomorrow am?), but you may want to see my specific
>>> version if you are doing testing. I can walk you through my tests on
>>> the website but do not want to publish the page, so check with me if
>>> you want to see a demo.
>
>
> One other detail: the embedded license isn't quite right. Maybe just a 
> cut and paste mistake? Here's a refresher for everyone on how Fluid's 
> licensing works:
>
> http://wiki.fluidproject.org/display/fluid/Embedded+Fluid+license
>
> In short:
>  * When you create a file, add your institution's name (or your own, 
> if you're an independent contributor) to the copyright statement.
>
> * If you're modifying an existing file, check to see if your 
> institution's (or your own) name is listed as a copyright holder. If 
> not, add it, since some of the IP in the file will be yours.
>
> So, in this case, only be University of Toronto should be listed, 
> since no one else has worked on the file yet.
>
> Colin
>
> ---
> Colin Clark
> Technical Lead, Fluid Project
> Adaptive Technology Resource Centre, University of Toronto
> http://fluidproject.org
>