code for FLUID-2925

[Colin Clark]

Hey Laurel and Jacob,

Couple of quick comments inline...

On 12-Jun-09, at 9:10 AM, Jacob Farber wrote:
> When looking for the minification flag, it looks like your checking  
> whether or not the variable is set.
> Im not 100% sure, but I think which Justin's latest form setup you  
> will always have a set value for compression ("minified" vs.  
> "source") as opposed to true vs. null.

It's never a bad thing to check for the presence of a value before  
operating on it. With a web service, it's better to not make  
assumptions just because you know how the client-side implementation  
works.

>> Jacob - can you review this code and let me know if there is anything
>> you would like to see altered or fixed? I can provide the generalized
>> config.php asap (tomorrow am?), but you may want to see my specific
>> version if you are doing testing. I can walk you through my tests on
>> the website but do not want to publish the page, so check with me if
>> you want to see a demo.


One other detail: the embedded license isn't quite right. Maybe just a  
cut and paste mistake? Here's a refresher for everyone on how Fluid's  
licensing works:

http://wiki.fluidproject.org/display/fluid/Embedded+Fluid+license

In short:
  * When you create a file, add your institution's name (or your own,  
if you're an independent contributor) to the copyright statement.

* If you're modifying an existing file, check to see if your  
institution's (or your own) name is listed as a copyright holder. If  
not, add it, since some of the IP in the file will be yours.

So, in this case, only be University of Toronto should be listed,  
since no one else has worked on the file yet.

Colin

---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org