refreshView() in Progress? (was Fwd: [Commits] svn commit: 6607)

[Colin Clark]

Hey Eli,

Awesome commit. Nice to see that we're able to simplify the Progress  
component's API over time, and it's great to see it getting some use  
outside Uploader, too.

Begin forwarded message:

> In Progress changed this:
>
> 	that.refresh = function (newProgressBarElm) {
>    	if (newProgressBarElm) {
>        	that.progressBar = newProgressBarElm;
>    	}
>
>    	repositionIndicator(that);
> 	};
>
> To this:
>
> 	that.refresh = function () {
>    	repositionIndicator(that);
> 	};


One super minor point. Should this method be named refreshView() to be  
consistent with our framework-wide convention? refreshView() is  
typically a method implemented by all Views, and is responsible for re- 
drawing the component when a change has been made in the model or  
state of the component.

Is this the sort of thing you intend the refresh() method to be used  
for, or does it do something different?

Again, nice work on this.

Colin

---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org