Stylesheet linting
Cindy Li
cli at ocadu.ca
Thu Oct 1 21:18:36 UTC 2020
Hi Tony, I issued a PR <https://github.com/fluid-project/fluid-grunt-lint-all/pull/17> to update the doc. Also added a couple of thoughts in the PR description. Please feel free to comment. Thanks.
> On Oct 1, 2020, at 5:48 AM, Tony Atkins <tony at raisingthefloor.org> wrote:
>
> Hi, Cindy.
>
> I agree, and it probably wouldn't take much work to expand the README with a few examples, especially since there are handy examples of custom configuration in the tests. Can you write that up?
>
> Cheers,
>
>
> Tony
>
> On Mon, 28 Sep 2020 at 15:03, Cindy Li <cli at ocadu.ca <mailto:cli at ocadu.ca>> wrote:
> Thanks for the information, Tony. This is great.
>
> It will be really useful to document this feature in the fluid-grunt-lint-all README.
>
>> On Sep 28, 2020, at 5:19 AM, Tony Atkins <tony at raisingthefloor.org <mailto:tony at raisingthefloor.org>> wrote:
>>
>> Hi, Cindy.
>>
>> When working on the plugin, I explicitly wanted to make sure that it was possible to configure settings per project. As an example, here is the test fixture I use to confirm that I can pass a custom configuration option to each of the tasks that fluid-grunt-lint-all currently handles:
>>
>> https://github.com/fluid-project/fluid-grunt-lint-all/blob/master/tests-Gruntfile-options-override.js <https://github.com/fluid-project/fluid-grunt-lint-all/blob/master/tests-Gruntfile-options-override.js>
>>
>> I would expect for any new tasks such as CSS linting to also provide the ability to configure new options per project.
>>
>> Cheers,
>>
>>
>> Tony
>>
>> On Fri, 25 Sep 2020 at 15:23, Cindy Li <cli at ocadu.ca <mailto:cli at ocadu.ca>> wrote:
>> One thought is, it might be helpful if fluid-grunt-lint-all could be flexible enough to allow the overriding of configurations, ideally for all linting tools it uses.
>>
>> One example is, most of our projects uses 4 spaces as indentations but at least WeCount project uses tabs as indentations. The switch to tabs is to allow developers to define their own preferred mapping from a tab to spaces in their IDEs, for the inclusion purpose. ;)
>>
>> Extending from it, individual projects may have their own linting requirements for their own reasons. It would be nice if fluid-grunt-lint-all could accommodate varied configurations.
>>
>> Thanks.
>>
>> Cindy
>>
>>> On Sep 25, 2020, at 8:52 AM, Ned Zimmerman <nzimmerman at ocadu.ca <mailto:nzimmerman at ocadu.ca>> wrote:
>>>
>>> Thanks, Cindy. Having worked with the stylelint configuration on We Count, what are your thoughts? Are there any changes you'd recommend?
>>>
>>> Cheers,
>>> Ned
>>> —
>>> Ned Zimmerman (he/him)
>>> Senior Inclusive Developer
>>> Inclusive Design Research Centre, OCAD University
>>> https://idrc.ocadu.ca <https://idrc.ocadu.ca/>
>>>
>>> On 2020-09-25, 9:26 AM, "Cindy Li" <cli at ocadu.ca <mailto:cli at ocadu.ca>> wrote:
>>>
>>> Great idea. +1
>>>
>>>> On Sep 24, 2020, at 10:42 AM, Ned Zimmerman <nzimmerman at ocadu.ca <mailto:nzimmerman at ocadu.ca>> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> I wanted to propose that we create a shareable Stylelint configuration for Fluid projects along the lines of eslint-config-fluid. This could be added to fluid-grunt-lint-all and used as a starting point in various projects. Stylelint is currently in use in the new IDRC website and in the We Count website. I created a JIRA for this (FLUID-6555) and there are some relevant links there. Eager to hear others' thoughts on this and I'm happy to start working on it if it sounds like a good idea to others.
>>>>
>>>> Cheers,
>>>> Ned
>>>> —
>>>> Ned Zimmerman (he/him)
>>>> Senior Inclusive Developer
>>>> Inclusive Design Research Centre, OCAD University
>>>> https://idrc.ocadu.ca <https://idrc.ocadu.ca/>
>>>>
>>>> _______________________________________________________
>>>> fluid-work mailing list - fluid-work at lists.idrc.ocad.ca <mailto:fluid-work at lists.idrc.ocad.ca>
>>>> To unsubscribe, change settings or access archives,
>>>> see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work <https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work>
>>>
>>>
>>
>> _______________________________________________________
>> fluid-work mailing list - fluid-work at lists.idrc.ocad.ca <mailto:fluid-work at lists.idrc.ocad.ca>
>> To unsubscribe, change settings or access archives,
>> see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work <https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20201001/25965faa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1487 bytes
Desc: not available
URL: <http://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20201001/25965faa/attachment.p7s>
More information about the fluid-work
mailing list