"extra" functionality in the fullscreen function
Novak, Alexey
anovak at ocadu.ca
Mon Feb 27 22:10:52 UTC 2012
Hi there,
I was trying to apply CSS styling as well as change the videoPlayer HTML markup. Since transcripts should obviously go inside into the flc-videoPlayer-video-controller-area which should eliminate any dynamic css height changes and more.
But this problem is much more complex as I thought since it requires so many CSS changes in every div which is almost like playing Jenga when everything just collapses with one single tiny change.
But I was thinking that we still can move out all that extra styling code from the fullscreen function away which will also allow us to remove fullscreen function call from the finalInit in the videoPlayer.
You can see my changes here and let me know what you think:
https://github.com/xOZx/videoPlayer/compare/michelled:demo...FLUID-4570
I put the styling functions into video.bind("loadedmetadata", function () {
There were initial set for the transcript height. Plus it should eliminate a chance that we are time dependent since at that point we suppose to have all measures based on the loaded video.
In the meantime, I will try an attempt of the markup change…
Let me know what you think. Thanks,
Alex
More information about the fluid-work
mailing list