[videoPlayer] Fluid 4559 - Re-wiring the timeupdate event to control the timing for the updates on time progress and captions (#13)
Li, Cindy
cli at ocadu.ca
Thu Feb 2 18:47:48 UTC 2012
Hi Antranig,
> js/VideoPlayer_captionLoader.js
>
> iv) Thanks for the improved commenting and returned public implementation for "convertToMilli". Where do such timestamps come from? Is it from one of the standard subtitle file formats? If so, this should be documented, and the conversion function parameterised in the component rather than hardcoded in the impl at lines 77 etc.
Can you elaborate on "the conversion function parameterised in the component rather than hardcoded in the impl"? Do you mean defining the conversion function as an invoker?
Thanks.
Cindy
More information about the fluid-work
mailing list