Patch for testing My Collection send email parameters

Svetoslav Nedkov snedkov at asteasolutions.com
Thu Feb 25 12:02:37 UTC 2010


Hi Colin and Justin,

I have created a patch that adds a unit test for the send email feature 
of My Collection, more precisely it tests that the parameters are 
correct before sending them to our server side send email script.

As a byproduct this patch fixes ENGAGE-339 (The My Collection unit tests 
are failing) which would be fixed by replacing an include in the test 
template. I hope that in this case this is ok.


For the current patch I have filed a Jira issue as a sub-issue of 
ENGAGE-435 (Create, edit, and update unit tests for Engage 0.3) and 
attached the patch to it:

http://issues.fluidproject.org/browse/ENGAGE-456


Also I have a question about the best approach for creating patches 
modifying the same code - this seems to limit the possibility to work on 
two issues before the first one is resolved. So the only solution I 
could think of was to create two patches for patch B created after patch 
A over the same code base - one that is supposed to be applied after 
patch A and one that could be applied separately without the changes 
from A. This will involve implementing the changes twice. Can you advise 
on that issue?



Regards,

Svetoslav



More information about the fluid-work mailing list