modification to build.xml

Colin Clark colin.clark at utoronto.ca
Fri Jun 19 14:34:04 UTC 2009


Hi Laurel,

On 18-Jun-09, at 11:50 AM, Laurel A. Williams wrote:

> Hi all,
>
> In order to get the customBuild working on the website I had to  
> modify the build.xml to point to the mvn settings file. This task is  
> listed as http://issues.fluidproject.org/browse/FLUID-2937
> I've attached a patch to the JIRA for review.

A good starting point, but this doesn't look quite right. In the  
patch, we've got a proliferation of highly similar or even identical  
code, all revolving around this set of conditionals for the platform  
and the Maven settings file. I think this can probably be refactored  
into a less repetitive form.

Worst case, Ant's <if> task should do the trick. Another option is to  
revisit this issue of the settings.xml file and see if there's a  
simpler way to resolve it.

Colin

---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org