code for FLUID-2925 and FLUID-2922

[Colin Clark]

Hi Laurel,

Nice work, and the code looks good. Couple of comments:

1. At the end of the file, you've got an else block with a comment: "// 
TODO what to do if the var wasn't set?" In this case, you should  
return an appropriate HTTP error. 400 is probably right.

2. There's enough fiddly string manipulation code here that you may  
want to cook up some unit tests for your core logic. It should be  
fairly straightforward to do.

Colin

On 18-Jun-09, at 4:18 PM, Laurel A. Williams wrote:

> Is there anyone else besides Jacob who feels familiar enough with  
> PHP to review the file jsonProcessor.php attached to FLUID-2922?  
> Jacob is really busy and hasn't been able to get to it yet.
> It would be really helpful to me if someone else could review it and  
> provide feedback.
>
> Thanks.
>
> Laurel
>
> Laurel A. Williams wrote:
>> Hi all,
>>
>> I've made more progress on the customBuild tool, server side.
>> I have uploaded more code for review to the JIRA tasks mentioned in  
>> the subject line of this email.
>>
>> 1) I revised the generalized config.php and fixed one small bug as  
>> well as adding some constants for jsonProcessor.php - I uploaded  
>> the same file to both JIRA's so it won't be hard to find.
>>
>> 2) I wrote jsonProcessor.php based on the ParserPrinter.php file  
>> that was used for the non-javascript version of the custom build  
>> tool. This is a first pass at reading in the json files and  
>> returning a concatenated string containing all the json data (also  
>> in json format). To do still - further error checking. Figure out  
>> how the client is requesting this data and how to return the data  
>> to the client.
>>
>> Jacob - looking forward to your thoughts.
>>
>> Laurel
>>
>
> -- 
> Laurel A. Williams
> Adaptive Technology Resource Centre
> University of Toronto
>
> _______________________________________________________
> fluid-work mailing list - fluid-work at fluidproject.org
> To unsubscribe, change settings or access archives,
> see http://fluidproject.org/mailman/listinfo/fluid-work

---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org