Slushy Infusion 0.8 code reviews
Colin Clark
colin.clark at utoronto.ca
Tue Feb 17 23:16:36 UTC 2009
Hi Justin and all,
I've done the last few reviews of commits done while the repository
was slushy, as well as the couple of linting-related tweaks that snuck
in after freeze. Here are my notes:
* We debated the best approach to fixing FLUID-2243, and Antranig's
second commit against this ticket is looking really good. Check the
channel logs for a summary. +1 for inclusion in Infusion 0.8.
* I reviewed the fix for FLUID-2248 and it is a reasonable workaround.
There's more to this issue, but this give us a decent fix until we can
resolve the underlying issues. +1
* FLUID-1939: a couple of separate unit tests commits. The change to
fluid.jById in r6522 is reasonable and gets the Reorderer tests
passing again. The new test in RendererTests.js at r6524 is also
reasonable.
* The linting in r6523 and 6525 all looks good.
In short, we're good to go. We squashed a lot of bugs this round,
which is really exciting.
Colin
---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org