[Decapod] FLUID-3314 Request for a code review
Boyan Sheytanov
boyan.sheytanov at asteasolutions.com
Fri Dec 11 13:33:25 UTC 2009
Hi all,
I've made the finishing touches on Decapod's Capture screen
functionality. My code is committed in the SVN repository and supports
the following:
1. When you open the capture screen, a thumbnail with text "No images
captured yet" is the only one shown. The preview area says "No preview
available". You are able to take pictures.
2. When you click on the 'Take picture' button, the empty thumbnail is
replaced by a picture from the local file system (in
../../server/testData/). This *does not* make calls to the server. The
image taken is selected (focused), which makes the full-sized version
appear in the preview area. Behind the scenes, the image is added to
the component's model.
3. You can take as many pictures as you like. The interface will
repeatedly iterate over the sample pictures we have currently (some
nice nature photos I've taken, we need a better set of test data
(images with dewarped text, etc.) prior to releasing).
4. You can delete pictures by... (surprise) pressing the 'Delete'
button. This will remove the image from the model and from the markup
and will select the next image. If the last image is deleted, the
previous image will be selected.
5. If you delete all images, the blank thumbnail and preview area are
shown (as in 1).
6. Links for fixing, comparing and exporting images are clickable, but
do nothing currently as we do not have the screens for these
components.
I'll be happy to see your notes and comments on the code I've written
as there might be a fair amount of things to be improved (The fact
that the code works doesn't mean that it is written in the best
possible way, probably there are things I have not thought about).
I'll be travelling today and won't be able to join the daily stand-up
meeting, so consider this a status update as well.
The next steps I will take are (not necessarily in the order specified):
1. Write some unit tests for the Capture component (ah, I've been
promising this for a week or so).
2. Get acquainted in more detail with the FSS, probably apply some
basic styling (depending on the discussion on Monday).
3. Get acquainted with Michelle's work on Kettle and work together
with her on integrating the UI and the server.
Have a wonderful sunny/snowy weekend everyone,
Boyan
More information about the fluid-work
mailing list