FLUID-1935 Review: Inconsistencies?
Anastasia Cheetham
a.cheetham at utoronto.ca
Fri Dec 12 22:21:23 UTC 2008
I've reviewed these css changes, and commented on the JIRA, but since
it's late and most people won't necessarily be tracking the JIRAs,
I've reproduced my comments below:
I'm seeing some inconsistency in naming of styles for components. The
uploader styles all start with "fl-uploader-" i.e. "fl-" followed by
the component name (see fluid.components.uploader.css).
But other components use style names that start with the component
name i.e. there is no "fl-" prefix (e.g. "ui_options_container" and
"ui-dialog" and "inlineEdit-invitation" and "orderable-*")
Should we decide on a convention and stick to it, or was there a
reason for the existing scheme?
--
Anastasia Cheetham a.cheetham at utoronto.ca
Software Designer, Fluid Project http://fluidproject.org
Adaptive Technology Resource Centre / University of Toronto
More information about the fluid-work
mailing list