Code review: FLUID-1942

Antranig Basman antranig at caret.cam.ac.uk
Mon Dec 8 23:36:42 UTC 2008


Hi there - I have looked at this patch, and it appears benign to me.

Cheers,
A.

Colin Clark wrote:
> 
> Hi all,
> 
> I've created a fix for FLUID-1942 and attached a patch to the JIRA
> issue:
> 
> http://issues.fluidproject.org/browse/FLUID-1942
> 
> This fixes a number of small issues related to the progressive
> enhancement feature of Uploader, including:
> 
> * linking against the unminified version of swfobject.js
> * remove the unused swfupload-swfobject.js file
> * ensure that the licenses are correct and up to date
> * ensuring that the build scripts include swfobject.js and
> ProgressiveEnhancement.js
> 
> Can someone give it a quick review before I go ahead and commit it as
> part of the bug parade?
> 
> Colin
> 
> ---
> Colin Clark
> Technical Lead, Fluid Project
> Adaptive Technology Resource Centre, University of Toronto
> http://fluidproject.org
> 
> _______________________________________________________
> fluid-work mailing list - fluid-work at fluidproject.org
> To unsubscribe, change settings or access archives,
> see http://fluidproject.org/mailman/listinfo/fluid-work



More information about the fluid-work mailing list